Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for bootupd/bootc ostree containers #1037

Closed

Conversation

VladimirSlavik
Copy link
Contributor

@VladimirSlavik VladimirSlavik commented Dec 7, 2023

WIP, needs some more checking...

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I think the main information that want from this test is a confirmation that the final system is bootable. Can you reuse here some parts of the reboot test to verify that?

The /etc directory is writable from %post also with ostree,
while /usr/libexec only on normal systems.
@VladimirSlavik
Copy link
Contributor Author

VladimirSlavik commented Dec 12, 2023

Still WIP, can't get the validation to work. Given that both ostree and reboot tests have special detection, that's... expected, I guess

@jikortus
Copy link
Contributor

Here's a couple of findings related to earlier discussions with @VladimirSlavik which should likely be taken into account when finishing the test:

  • The container image used in the test doesn't likely support BTRFS by default (no dracut module in initrd), so it will likely fail to mount root fs.
  • /boot partition may need to have a boot label set, so that kernel and initrd files are properly found by GRUB.
  • not sure if GRUB will find kernel and initrd files if /boot doesn't reside on a separate partition

@jikortus
Copy link
Contributor

jikortus commented Feb 6, 2024

Taking over the test development from Vladimir, will continue working on it after some higher priority tasks I've on my plate right now are done.

@rvykydal
Copy link
Contributor

rvykydal commented Feb 6, 2024

Thank you Jirko, I think eventually this test will replace the rpm-ostree-container-rhel9 which does not test booting of the target system, just presence of the payload). I am fixing it for now in #1052.

@rvykydal
Copy link
Contributor

rvykydal commented Feb 7, 2024

FYI, there is some tests renaming / consolidation undergoing: #1054

@rvykydal
Copy link
Contributor

rvykydal commented Apr 4, 2024

Follow-up in #1096

@rvykydal rvykydal closed this Apr 4, 2024
@VladimirSlavik VladimirSlavik deleted the master-bootupd branch May 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants